Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing version makes Yarn workspace fail #10140

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Missing version makes Yarn workspace fail #10140

wants to merge 4 commits into from

Conversation

Arthurmtro
Copy link

Actually, it's not possible to create a new remix project in a Yarn workspace and directly install packages, you have to manually add a version
image

By doing this change, we just ensure Remix can be seamlessly integrated into a yarn workspace :)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3e0cb60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 19, 2024

Hi @Arthurmtro,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 19, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@Arthurmtro
Copy link
Author

Hello !
Any news on that possible quick fix ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed template:remix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arthurmtro @brophdawg11